Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array in SubMessage not shown in raw-view #4

Open
dirk-thomas opened this issue Apr 24, 2017 · 2 comments · May be fixed by #152
Open

Array in SubMessage not shown in raw-view #4

dirk-thomas opened this issue Apr 24, 2017 · 2 comments · May be fixed by #152
Labels
bug

Comments

@dirk-thomas
Copy link
Contributor

From @alex-gee on February 26, 2015 17:10

This issue is that i use

OuterMessage:
Header header
ClusterMsg[] clusters

ClusterMsg:
uint8[] indices
string label

But the content inside the raw view looks like in the image.
If i play the bagfile and listen with "rostopic echo /labels" i can see that the array is filled correctly

Update: The problem could be the "uint8". Apparently there is some cast to (int) missing before calling the print function.

rqt_bag_issue

greetings!

Copied from original issue: ros-visualization/rqt_common_plugins#305
@dirk-thomas
Copy link
Contributor Author

The raw view in rqt_bag tries to determine the field type based on the Python type (ros-visualization/rqt_common_plugins@6640ce2#diff-09908728fca83b95e445d7e4438e4773R193). This is simply not feasible since the logic for that is very complex. Instead it should use functions provided by genmsg or genpy to determine the type based on the actual message definition.

@ablasdel @trainman419 May be one of you guys will find some time to look into this. A good starting point might be to look how rostopic echo does it (see https://github.com/ros/ros_comm/blob/1df83085f88313bfe3cc6510690726939b157772/tools/rostopic/src/rostopic/__init__.py#L575).

@dirk-thomas
Copy link
Contributor Author

From @ablasdel on March 4, 2015 19:16

This seems like a very important bug to fix but at the moment I don't have any time to show rqt any love.

@dirk-thomas dirk-thomas mentioned this issue Apr 24, 2017
Closed
po1 added a commit to po1/rqt_bag that referenced this issue Feb 20, 2024
@po1
raw_view: fix display of array types
8700eb4 
Fixes ros-visualization#4 

Testing done:
- [x] display a message with a `std_msgs.msg.Float32MultiArray` field
@po1 po1 linked a pull request Feb 20, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

raw_view: fix display of array types po1/rqt_bag
1 participant
@dirk-thomas