Skip to content
This repository has been archived by the owner on May 23, 2018. It is now read-only.

Immutable reducer updates state with mutable objects #12

Open
ivan-nejezchleb opened this issue Apr 7, 2017 · 2 comments
Open

Immutable reducer updates state with mutable objects #12

ivan-nejezchleb opened this issue Apr 7, 2017 · 2 comments

Comments

@ivan-nejezchleb
Copy link

ivan-nejezchleb commented Apr 7, 2017

If redux-router5 used as a part of immutable state it creates state updates, which contain plain JS objects.
It causes that you cant use immutable state.getIn(['route', 'params', 'paramName']) to get param's value from URL
Immutable router should handle state updates fully in immutable manner.

I will prepare PR to fix this, if it is found as a valid bug

@troch
Copy link
Member

troch commented Apr 8, 2017

I'm not sure I understand. Are you talking about this package or router5 package?

@ivan-nejezchleb
Copy link
Author

ivan-nejezchleb commented Apr 10, 2017

This package. Immutable state in redux should consist only from immutable Maps, Lists and so on. But here reducer from immutable folder sets plain JS objects into state. Creating PR, hope it will clarify this
#13

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants