Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect links / URLs, open on ctrl+click #182

Open
alexsapps opened this issue May 25, 2018 · 14 comments
Open

Detect links / URLs, open on ctrl+click #182

alexsapps opened this issue May 25, 2018 · 14 comments
Assignees

Comments

@alexsapps
Copy link

The normal SSH/hterm/shell app for Chrome detects URLs and underlines them on hover and opens the link on ctrl+click. I'd like this for mosh-chrome too.

@rpwoodbu
Copy link
Owner

I am surprised to learn that the released Mosh for Chrome has such an old hterm that this feature isn't available! I really need to do a release.

In the interim, you can install "Mosh for Chrome (dev)" from the Chrome Web Store and get the ctrl+click functionality. (Although, I have not seen underlines... is that an option in hterm?)

@rpwoodbu rpwoodbu self-assigned this May 26, 2018
@vapier
Copy link
Contributor

vapier commented May 26, 2018

it's news to me that hterm automatically underlines links :)

maybe you're thinking of OSC-8 instead ?

ctrl+click does work in the latest hterm though.

@alexsapps
Copy link
Author

Sorry I was wrong about automatic underlining. My usual SSH host was down at the time of writing so I just went off the best of my (wrong) memory.

@gordol
Copy link

gordol commented Jun 15, 2018

fwiw, i'm running this on latest hterm, and URLs are not clickable...

perhaps there is some other flag to pass to make that possible.

@vapier
Copy link
Contributor

vapier commented Jun 15, 2018

it's hard to guess at what you're trying to do exactly. did you hold Ctrl down before clicking?

@gordol
Copy link

gordol commented Jun 22, 2018

did you hold Ctrl down before clicking

yep.

i figured out the problem... it works if i'm not in tmux, otherwise, tmux seems to be capturing the mouse input and it never triggers, or something... maybe it's the ctrl modifier key. either way, ctrl+click on latest hterm does indeed work, in a plain shell

@vapier
Copy link
Contributor

vapier commented Jun 22, 2018

sounds like you turned on tmux's mouse mode

@gordol
Copy link

gordol commented Jun 22, 2018

mouse mode or not, it doesn't work within tmux, btw. i know how to turn mouse mode on and off, lol

@vapier
Copy link
Contributor

vapier commented Jun 23, 2018

my point is, if you've turned on mouse mode, then hterm should not be hijacking ctrl+mouse for its own use. your clicks (including key modifiers) are sent to the remote side so it can interpret things.

if you google for 'tmux mouse mode', you'll find some docs to control it.

@gordol
Copy link

gordol commented Jun 23, 2018

... I literally just said I know about mouse mode in tmux. what's your point? lol

@gordol
Copy link

gordol commented Jun 23, 2018

this works if you just use latest libapps. see my fork here for an example: gordol@75b0057

@rpwoodbu
Copy link
Owner

rpwoodbu commented Jul 15, 2018

@gordol, be sure you're running "Mosh (dev)" from the Chrome Web Store. I mentioned in my first comment that this isn't in the released version (non-dev). I hope to do a release soon.

@gordol
Copy link

gordol commented Jul 15, 2018

I'm running my own fork that's more updated than the dev build in the app store.

@rpwoodbu
Copy link
Owner

rpwoodbu commented Jul 15, 2018

@gordol Sure, but I think you'll find this works at HEAD, which is pushed to "Mosh (dev)". (Yes, I know, I need to do a stable release...)

Also, I forgot to mention that I use tmux 100% of the time, and don't have troubles clicking links. I don't have mouse mode enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants