-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot extract go version info on minimal/reproducible/stripped binaries built with go1.14+ #14
Comments
testcases for default and symbol-stripped builds using standard/boringcrypto go versions 1.9-1.15 at #15 |
FTR the |
yeah, this library has the ability to extract version info directly from well-known assembly produced by the go compiler. it appears that needs updating for go 1.14+ |
Imported the cmd/go/internal/version implementation at c32140fa94cfc51a2152855825f57e27ae3ba133, and restored Symbols and TextRange to implement the gccgo and crypto checks. It looks like the amd64 matching had broken, but it should be more stable to just track what we do upstream with minimal modifications, so I replaced the core mechanism rather than fixing the matcher. Fixes rsc#14 Fixes rsc#12 Fixes rsc#11 Fixes rsc#7 Closes rsc#13 Closes rsc#9
This worked on go1.13:
But on 1.14+, the same steps result in an error about there being no symbol section:
On 1.15:
The text was updated successfully, but these errors were encountered: