Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys for RDF::Vocabulary::Term attributes should be symbols consistently. #309

Closed
cdchapman opened this issue Aug 12, 2016 · 5 comments
Closed

Comments

@cdchapman
Copy link

cdchapman commented Aug 12, 2016

The vocabulary writer currently only populates values with symbolic keys but the hash keys for term attributes are not all symbols, but a mix of strings and symbols. Keys that are not one of the vocabulary-specific predicates (e.g. dc:description) are not created as symbols, but as strings, and the objects of these string-keyed predicates are consequently not being populated in generated vocabularies.

@cdchapman
Copy link
Author

Actually I think this was already fixed in fc06d1f by @gkellogg. I thought I was running the latest code, but I am running v2.0.2. 😊

@cdchapman
Copy link
Author

Request for new release?

@gkellogg
Copy link
Member

We'll get one out in the next day or so.

@no-reply
Copy link
Member

👍 to a release.

I got #310 in, so we can have a real feature to ship with it. ;)

I noticed the inefficiency in #311 in the process. If we ship 2.1.0, I will probably backport this change to 2.0.x.

@cdchapman
Copy link
Author

👍 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants