-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove disable-gpu
default flag for Apple Silicon
#421
Comments
From https://developer.chrome.com/blog/headless-chrome Do I need the --disable-gpu flag? Only on Windows. Other platforms no longer require it. The --disable-gpu flag is a temporary work around for a few bugs. You won't need this flag in future versions of Chrome. See crbug.com/737678 for more information. So you are right, we need to add some conditionals for windows and mac most likely. Mind sending a PR? |
This patch aims to close the issue rubycdp#421 by doing the following: 1. Only including the `--disable-gpu` flag when running on Windows as it is not needed on other platforms and it causes issues on Mac ARM. 2. Adding the `--use-angle=metal` flag when running on Mac ARM so the browser uses the Metal API instead of OpenGL. Close rubycdp#421
This patch aims to close the issue #421 by doing the following: 1. Only including the `--disable-gpu` flag when running on Windows as it is not needed on other platforms and it causes issues on Mac ARM. 2. Adding the `--use-angle=metal` flag when running on Mac ARM so the browser uses the Metal API instead of OpenGL. Close #421
Thanks! |
The
disable-gpu
is part of the default Chrome options but it is causing issues with webpages using WebGL on Apple Silicon machine.I was able to make it work by removing the
disable-gpu
flag and adding the--use-angle=metal
flag via this small monkey-patch:Do you think this should be set by default for Apple Silicon, or at least stop adding the
disable-gpu
flag on this platform?I'm happy to provide a PR if needed.
The text was updated successfully, but these errors were encountered: