Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement non standard text highlight color #2412

Closed
3 tasks done
GabrielBittar opened this issue Jul 10, 2024 · 7 comments · Fixed by #2415
Closed
3 tasks done

[Feature] Implement non standard text highlight color #2412

GabrielBittar opened this issue Jul 10, 2024 · 7 comments · Fixed by #2415
Assignees
Labels
multiple issues priority: high Making completely new feature

Comments

@GabrielBittar
Copy link
Contributor

GabrielBittar commented Jul 10, 2024

Description

Implementing a non standard color at CSS ::selection > background may improve user experience. If this change looks like a good idea, I'd suggest using #714eff or #fbd449, since these are already in use in the website. Though the yellow one would also require a change on the text color, or it'd be unreadable.

Screenshots

purple

image

yellow, unreadable

image

but when text color goes darker, yellow seems fine again

image

Checklist

  • I have checked the existing issues
  • I have read the Contributing Guidelines
  • I am willing to work on this issue (optional)
@GabrielBittar GabrielBittar added the priority: high Making completely new feature label Jul 10, 2024
Copy link

Hello GabrielBittar!
Thank you for raising this issue! 😊 Your contribution is valuable to us! 😊

Please make sure to follow our Contributing Guidelines. 💪🏻

Please only work on an issue if you're assigned; otherwise, the PR will be automatically closed.
Our review team will carefully assess the issue and reach out to you soon! 😇
We appreciate your patience!

Copy link

#2411, #2408 is already opened by you
As per contributing guidelines, you can only work on 1 issue at a time.

@GabrielBittar
Copy link
Contributor Author

P.s.: sorry, I'd not call it "priority: high", I didn't see the label before I created the issue.

@rupali-codes
Copy link
Owner

@GabrielBittar you're assigned, we'll go with purple as per our theme.

@rupali-codes
Copy link
Owner

hey @GabrielBittar do we have any update on this?

@GabrielBittar
Copy link
Contributor Author

hey @GabrielBittar do we have any update on this?

Hey! Yes, #2415

Copy link

Thank you for contributing to LinksHub! Please take a moment to rate this repo's DX on EddieHub's RepoRater and give it a star ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multiple issues priority: high Making completely new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants