-
-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Implement non standard text highlight color #2412
Comments
Hello GabrielBittar! Please make sure to follow our Contributing Guidelines. 💪🏻 Please only work on an issue if you're assigned; otherwise, the PR will be automatically closed. |
P.s.: sorry, I'd not call it "priority: high", I didn't see the label before I created the issue. |
@GabrielBittar you're assigned, we'll go with purple as per our theme. |
hey @GabrielBittar do we have any update on this? |
Hey! Yes, #2415 |
Thank you for contributing to LinksHub! Please take a moment to rate this repo's DX on EddieHub's RepoRater and give it a star ⭐ |
Description
Implementing a non standard color at CSS ::selection > background may improve user experience. If this change looks like a good idea, I'd suggest using #714eff or #fbd449, since these are already in use in the website. Though the yellow one would also require a change on the text color, or it'd be unreadable.
Screenshots
purple
yellow, unreadable
but when text color goes darker, yellow seems fine again
Checklist
The text was updated successfully, but these errors were encountered: