compiletest: error emitter pretty svg tests don't normalize color differences between Windows and Unixes #135270
Labels
A-compiletest
Area: The compiletest test runner
A-diagnostics
Area: Messages for errors, warnings, and lints
A-testsuite
Area: The testsuite used to check the correctness of rustc
C-bug
Category: This is a bug.
D-diagnostic-infra
Diagnostics: Issues that affect all diagnostics, or relate to the diagnostic machinery itself.
O-windows
Operating system: Windows
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
jieyouxu
added
C-bug
rustbot
added
the
needs-triage
jieyouxu
added
A-diagnostics
github-project-automation
bot
moved this to Backlog
in compiletest maintenance and improvements
jieyouxu
added
the
D-diagnostic-infra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is the svg snapshots of the same test
test/ui/error-emitter/multiline-removal-suggestion.rs(the former is the reference Unix-blessed snapshot, the latter is generated on Windows with//@ only-linuxremoved), but I believe this fails on Windows because the exact colors chosen are different. I believe this is because there are certain cmd.exe default bright colors which are very hard to read, so we actually pick different colors on purpose.cc @estebank for FYI: I reasoned about the failure in #134664 incorrectly, I found out today after revisiting #132752, which is a different bug.
The text was updated successfully, but these errors were encountered: