Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add riscv64 support #40

Open
mkszuba opened this issue Jul 27, 2021 · 0 comments · May be fixed by #58
Open

Add riscv64 support #40

mkszuba opened this issue Jul 27, 2021 · 0 comments · May be fixed by #58

Comments

@mkszuba
Copy link

mkszuba commented Jul 27, 2021

Due to the fact riscv64 is not explicitly mentioned in include/marisa/base.h, MARISA_WORD_SIZE ends up being incorrectly set to 32 on this architecture. Fortunately, this is trivial to address - just add

|| (defined(__riscv) && (__riscv_xlen == 64))

to the end of the #if statement in base.h:31-34.

Confirmed to work on a physical rv64 Linux system.

References:
@cubercsl cubercsl mentioned this issue Oct 15, 2022
Merged
@ncopa ncopa mentioned this issue Apr 24, 2024
Open
ncopa added a commit to ncopa/marisa-trie that referenced this issue Apr 24, 2024
@ncopa
Fix detection of MARISA_WORD_SIZE
1e16775 
Detect the MARISA_WORD_SIZE independent of architecture.

Fixes: s-yata#40
Fixes: s-yata#57
Fixes: s-yata#44
Fixes: s-yata#46
Fixes: s-yata#56
@ncopa ncopa linked a pull request Apr 24, 2024 that will close this issue
Open
ncopa added a commit to ncopa/marisa-trie that referenced this issue Apr 30, 2024
@ncopa
Fix detection of MARISA_WORD_SIZE
6925413 
Detect the MARISA_WORD_SIZE independent of architecture.

Fixes: s-yata#40
Fixes: s-yata#57
Fixes: s-yata#44
Fixes: s-yata#46
Fixes: s-yata#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix detection of MARISA_WORD_SIZE ncopa/marisa-trie
1 participant
@mkszuba