Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take linter and other workflows into account #6

Open
tobiasdiez opened this issue Apr 2, 2023 · 1 comment
Open

Take linter and other workflows into account #6

tobiasdiez opened this issue Apr 2, 2023 · 1 comment

Comments

@tobiasdiez
Copy link

tobiasdiez commented Apr 2, 2023

Currently the linter workflow is broken on the develop branch: https://github.com/sagemath/sage/actions/runs/4584153146

It looks like one of the PRs enabled stricter linter rules, while another one introduced code that violated this new rule.

The merge queue feature of github would automatically make sure that such a situation cannot happen. I'm not sure whats the easiest solution to implement this using the custom release scripts, but could you please check that the 6/7 default workflows are green before pushing your branch onto develop @vbraun?

@mkoeppe
Copy link

mkoeppe commented Apr 2, 2023

The linters can also be run by using ./sage -tox -e pycodestyle-minimal,relint,codespell,rst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants