Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a preference for tab hiding #1054

Open
llewelld opened this issue Dec 31, 2023 · 0 comments
Open

Create a preference for tab hiding #1054

llewelld opened this issue Dec 31, 2023 · 0 comments
Labels
esr91 Changes required to support Gecko ESR 91
Milestone
esr91

Comments

@llewelld
Copy link
Member

Currently the tab/window hiding functionality can be enabled and disabled by setting the showHidden flag in the QML in TabView.qml:

https://github.com/llewelld/sailfish-browser/blob/e2b97dadf035ee3d94dd35264b2694934b858ef3/apps/browser/qml/pages/components/TabView.qml#L117C26-L117C26

  model: TabFilterModel {
      sourceModel: tabItem.privateMode ? webView.privateTabModel : webView.persistentTabModel
      showHidden: false
  }

To allow this to be set dynamically by the user we should create a preference that allows this to be configured using about.config.
@llewelld llewelld added the esr91 Changes required to support Gecko ESR 91 label Dec 31, 2023
@llewelld llewelld added this to the esr91 milestone Dec 31, 2023
@llewelld llewelld mentioned this issue Dec 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
esr91 Changes required to support Gecko ESR 91
Projects
None yet
Milestone
esr91
Development

No branches or pull requests
1 participant
@llewelld