Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/refactor all leftover piston code #65

Open
dshafer opened this issue Sep 14, 2021 · 0 comments
Open

Remove/refactor all leftover piston code #65

dshafer opened this issue Sep 14, 2021 · 0 comments

Comments

@dshafer
Copy link
Collaborator

dshafer commented Sep 14, 2021

There are several instances of old piston code in DDA which, if hit, produce very difficult-to-debug errors. Example: https://github.com/salesforce/django-declarative-apis/blob/master/django_declarative_apis/resources/resource.py#L222

This line returns an incompatible type for the method. If hit, this line causes an internal error in Django that entirely swallows the original stack trace.

We need to excise all of this leftover code, and increase test coverage to catch all corner/error cases in machinery/resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant