New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jettywrapper should explicitly require 'active_support/benchmarkable' #30

Open

cbeer opened this issue Sep 4, 2014 · 1 comment

Contributor

cbeer commented Sep 4, 2014

Lovely failure if you aren't in a Rails environment (with autoloading) already:

NameError: uninitialized constant ActiveSupport::Benchmarkable
/Users/cabeer/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/jettywrapper-1.8.2/lib/jettywrapper.rb:19:in `<class:Jettywrapper>'
/Users/cabeer/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/jettywrapper-1.8.2/lib/jettywrapper.rb:16:in `<top (required)>'

Contributor

atz commented Nov 11, 2014

Added dep to gemspec in https://github.com/sul-dlss/jettywrapper/commit/a26a7861c93c3e56ff4cf2faf8d6f38ae1260bab

mejackreed mentioned this issue

explicitly adds dependency for benchmarkable #35

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment