Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to specify fmin #223

Open
ryancoe opened this issue Apr 13, 2023 · 2 comments · May be fixed by #292
Open

Allow user to specify fmin #223

ryancoe opened this issue Apr 13, 2023 · 2 comments · May be fixed by #292
Assignees
@cmichelenstrofer
Labels
enhancement New feature or request
Milestone
v3.0

Comments

@ryancoe
Copy link
Collaborator

ryancoe commented Apr 13, 2023

We currently create the frequency vector using the fundamental (f1) and the number of frequencies (nfreq). However, this means that you can often wind up with a lot of low frequencies where no energy is present (see, e.g., omega < 1 below). One could reduce the pseudo-spectral problem size by cutting out these lower frequencies.

image

https://github.com/SNL-WaterPower/WecOptTool/blob/9d8f4ef76c86cedf8ed997d85e1698f2bebc15b7/wecopttool/core.py#L1264-L1291
@ryancoe ryancoe added the enhancement New feature or request label Apr 13, 2023
@cmichelenstrofer cmichelenstrofer self-assigned this Jun 26, 2023
@dtgaebe
Copy link
Collaborator

dtgaebe commented Aug 23, 2023

This will also be important to create the WEC from_impedance. I was looking into the frequency response functions data in fbWecCtrl of our pet WECs and f_min is 0.1Hz for both the WaveBot and FOSWEC. The fundamental of 0.1Hz is to coarse to capture the dynamics (especially the FOSWEC).

While the extrapolated impedance looked alright in a plot, I suddenly started having convergence issues, so we might want prioritize this enhancement even before V3 @cmichelenstrofer ?

@ryancoe ryancoe mentioned this issue Oct 6, 2023
Closed
2 tasks
@cmichelenstrofer cmichelenstrofer linked a pull request Nov 1, 2023 that will close this issue
Draft
@cmichelenstrofer
Copy link
Member

cmichelenstrofer commented Nov 1, 2023 •
edited
Loading

We will want to retain the mean (DC) component even if we set fmin>1 . See #86. This will require some more effort...

@cmichelenstrofer cmichelenstrofer added this to the v3.0 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmichelenstrofer cmichelenstrofer

Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

Set a different starting frequency. Closes #223 cmichelenstrofer/WecOptTool
3 participants
@ryancoe @cmichelenstrofer @dtgaebe