Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More conventional score method names #121

Open
GrantGryczan opened this issue Dec 15, 2021 · 1 comment
Open

More conventional score method names #121

GrantGryczan opened this issue Dec 15, 2021 · 1 comment
Labels
enhancement New feature or request
Milestone
Future Release

Comments

@GrantGryczan
Copy link
Contributor

GrantGryczan commented Dec 15, 2021 •
edited
Loading

Many of the current names are very unnatural to type and to read.

These should be renamed:

  • greaterOrEqualThan -> greaterThanOrEqualTo
  • lowerOrEqualThan -> lessThanOrEqualTo
  • lowerThan -> lessThan
  • equalTo -> equals
  • multipliedBy -> times
  • modulo -> mod
  • moduloBy -> modBy

Any of the last four could be aliases instead if that's preferable to renaming. The first three are completely unnatural phrasings though.
@GrantGryczan GrantGryczan changed the title More conventional score comparison method names More conventional score method names Dec 15, 2021
@TheMrZZ
Copy link
Collaborator

TheMrZZ commented Dec 15, 2021

I agree that the 4 last should be aliases, for consistency mostly.

@MulverineX MulverineX added the enhancement New feature or request label Jan 30, 2023
@MulverineX MulverineX added this to the Future Release milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Future Release
Development

No branches or pull requests
3 participants
@MulverineX @GrantGryczan @TheMrZZ