Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Resources & /variables utilities in every argument where it makes sense #172

Open
GrantGryczan opened this issue Mar 10, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@GrantGryczan
Copy link
Contributor

GrantGryczan commented Mar 10, 2022

Like how execute.run accepts the parameters of MCFunction. It would make checks with predicates that are only ever used once much less verbose.

I am iffy on this suggestion though, because there are a lot of commands that could receive the same treatment but don't (for example, the item command could allow the creation of ItemModifiers via its parameters too), and I'm not confident this is a good design pattern for anything beyond functions. More opinions (or deeper consideration) would be needed.

@MulverineX
Copy link
Member

All places where a Resource or /variables utility can be turned into a simple value it should be supported, because Sandstone is supposed to be a rolling abstraction precompiler where you can choose the amount of features you want to use. This will be done alongside other missing support in a future release.

@MulverineX MulverineX added the bug Something isn't working label Jan 30, 2023
@MulverineX MulverineX added this to the Future Release milestone Jan 30, 2023
@MulverineX MulverineX changed the title Let execute.if.predicate accept the parameters of Predicate Allow Resources & /variables utilities in every command argument where it makes sense Jan 30, 2023
@MulverineX MulverineX added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 30, 2023
@MulverineX MulverineX changed the title Allow Resources & /variables utilities in every command argument where it makes sense Allow Resources & /variables utilities in every argument where it makes sense Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants