Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request completion for criu command #1308

Open
1 of 2 tasks
eval-exec opened this issue Jan 9, 2025 · 2 comments
Open
1 of 2 tasks

Request completion for criu command #1308

eval-exec opened this issue Jan 9, 2025 · 2 comments

Comments

@eval-exec
Copy link

eval-exec commented Jan 9, 2025

Describe the feature/solution

Request completion for criu command.

Maintenance (please complete the following information)

@akinomyoga
Copy link
Collaborator

akinomyoga commented Jan 9, 2025

The provided link is not a link to a query about shipping the completion in the upstream. Please first ask the upstream about whether they can ship a completion setting. After that, please update the link.

edit: I have unchecked the item.

@akinomyoga
Copy link
Collaborator

Also, the issue template should have been included the following sentence.

See CONTRIBUTING.md, many of the considerations for new completions

Have you read CONTRIBUTING.md? Please check the second paragraph of CONTRIBUTING.md:

However, before submitting a completion to us, first consider submitting it to
the project that ships the commands your completion is for. Having the
completion shipped along with the command opens up some liberties we don't have
if the completion is included with bash-completion. For example, we generally

This actually also applies to the request for a new completion. Have you aksed if the upstream can ship the completion by themselves? I searched for any related issues or pull requests in the upstream repository, but I could not find any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants