Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secret-tool completion file conflicting with upstream file #1317

Open
3 tasks done
rffontenelle opened this issue Jan 16, 2025 · 3 comments · May be fixed by #1319
Open
3 tasks done

secret-tool completion file conflicting with upstream file #1317

rffontenelle opened this issue Jan 16, 2025 · 3 comments · May be fixed by #1319

Comments

@rffontenelle
Copy link

rffontenelle commented Jan 16, 2025

Describe the bug

Since libsecret 0.21.6, the completion file secret-tool is include and installed in the very same directory as bash-completion. For downstream distros this may cause file conflicts blocking both packages to be installed at the same time. For instance, see this issue this issue in Arch Linux for libsecret bash-completion package.

EDIT: issue moved from libsecret to bash-completion

Should the secret-tool completion file be removed from bash-completion, since the upstream now ships it?

To reproduce

On Arch Linux:

  1. Install bash-completion (right now, version 2.15.0-1)
  2. Enable testing repositories
  3. Try to install libsecret 0.21.6-1
  4. Arch's package manager (pacman) fails with message:

libsecret: /usr/share/bash-completion/completions/secret-tool exists in filesystem (owned by bash-completion)

Expected behavior

No conflict between libsecret and bash-completion, allowing both to be installed.

Versions (please complete the following information)

  • Operating system name/distribution and version: Arch Linux (x86_64, rolling release)
  • bash version, echo "$BASH_VERSION": 5.2.37(1)-release
  • bash-completion version, (IFS=.; echo "${BASH_COMPLETION_VERSINFO[*]}"): 2.15.0

Additional context

Debug trace

@david-geiger
Copy link

Same issue here on Mageia Cauldron!

@scop
Copy link
Owner

scop commented Jan 21, 2025

Interesting. Per https://github.com/GNOME/libsecret/tree/0.20.5/bash-completion it looks like upstream completion has been available since 0.20.5, so about 3 years, but this is the first time I've heard of the conflict.

Our standard action in cases like this is to deprecate our completion, which in this case is a bit of a shame as it seems much more featureful than the upstream one. Perhaps someone would be interested in submitting our goodies for inclusion there?

@scop
Copy link
Owner

scop commented Jan 21, 2025

Anyway in the meantime, I suggest asking for a fix from your distro packagers, either the libsecret or bash-completion one, so that only one of them ships the completion in the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants