Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] completion subcommand #51

Closed
mathieu-benoit opened this issue Oct 15, 2024 · 2 comments · Fixed by #60
Closed

[feature request] completion subcommand #51

mathieu-benoit opened this issue Oct 15, 2024 · 2 comments · Fixed by #60
Assignees
@Somsubhra
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mathieu-benoit
Copy link
Contributor

Let's have a completion subcommand for score-k8s, like we have with score-compose, for consistency:

$ score-compose --help
...
Available Commands:
...
  completion    Generate the autocompletion script for the specified shell
...
@mathieu-benoit mathieu-benoit added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 15, 2024
This was referenced Oct 17, 2024
Merged
Merged
@Somsubhra
Copy link
Contributor

Please assign this issue to me - I've added PR here #60 and doc here score-spec/docs#124 - please review. Thanks!

mathieu-benoit added a commit that referenced this issue Oct 21, 2024
@mathieu-benoit
Merge pull request #60 from Somsubhra/add-completion-command
50f6bd1 
#51 Enable completion command to generate shell completions
@mathieu-benoit mathieu-benoit linked a pull request Oct 21, 2024 that will close this issue
#51 Enable completion command to generate shell completions #60
Merged
7 tasks
@mathieu-benoit
Copy link
Contributor Author

Done in #60.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Somsubhra Somsubhra

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#51 Enable completion command to generate shell completions Somsubhra/score-k8s
2 participants
@Somsubhra @mathieu-benoit