Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The react-popover library, used in the color sliders, is unmaintained #1122

Open
adroitwhiz opened this issue Jun 14, 2020 · 7 comments
Open

Comments

@adroitwhiz
Copy link
Contributor

Expected Behavior

We should use libraries that still receive updates

Actual Behavior

react-popover, used for the color slider popover, was last updated 2 years ago.

It contains a bug where it recognizes mouse and touch events but ignores pointer events, which is blocking scratchfoundation/paper.js#37. I was hoping to get a fix merged into it, but they don't seem to be looking at any pull requests.

@Jacco
Copy link
Contributor

Jacco commented Jun 14, 2020

This one seems to have about the same functionality and is still maintained:

https://www.npmjs.com/package/react-tiny-popover

You could also consider rolling a self-made version to have one less dependancy.

@adroitwhiz
Copy link
Contributor Author

I looked into react-tiny-popover but it uses createRef which isn't supported in the old version of React that Scratch currently uses.

@Jacco
Copy link
Contributor

Jacco commented Jun 14, 2020

Yikes ok, version 16 is used right?

@adroitwhiz
Copy link
Contributor Author

Yes, but there are a variety of point-releases that add new features and deprecate (but don't break) old ones.

@Jacco
Copy link
Contributor

Jacco commented Jun 14, 2020

popperjs

As far as I can see you have to do a bit of work yourself but seems good.

@Jacco
Copy link
Contributor

Jacco commented Jun 14, 2020

Ah also 16.8.0

@fsih
Copy link
Contributor

fsih commented Jun 14, 2020

We should look at updating our React version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants