From abc9eddd03c6e45fd5c47e80143467c5115e5e88 Mon Sep 17 00:00:00 2001
From: Pfalzgraf <Skyfold@users.noreply.github.com>
Date: Thu, 19 Dec 2024 02:22:30 +0000
Subject: [PATCH] removes pre-commit from nix check so CI only checks code

hpack, fourmolu, hlint and nixfmt output depend on the exact versions
being used to have the same output. The pre-commit-check can fail if
even minor versions are different. This makes the check very brittle.
---
 flake.nix | 83 +++++++++++++++++++++++++------------------------------
 1 file changed, 37 insertions(+), 46 deletions(-)

diff --git a/flake.nix b/flake.nix
index cc1e5a3..ed5bf29 100644
--- a/flake.nix
+++ b/flake.nix
@@ -87,10 +87,11 @@
           inherit system;
         };
 
-        pkgsOverlayed = import inputs.nixpkgs {
-          inherit system;
-          overlays = [ self.overlays.default ];
-        };
+        ghcPkgs =
+          (import inputs.nixpkgs {
+            inherit system;
+            overlays = [ self.overlays.default ];
+          }).haskell.packages;
 
         # Define GHC versions list
         ghcVersions = [
@@ -98,14 +99,6 @@
           "982"
         ];
 
-        # Create an attrset of GHC packages
-        ghcPkgs = builtins.listToAttrs (
-          map (version: {
-            name = "ghc${version}";
-            value = pkgsOverlayed.haskell.packages."ghc${version}";
-          }) ghcVersions
-        );
-
         example-src = nix-filter.lib {
           root = ./example;
           include = [
@@ -116,8 +109,23 @@
           ];
         };
 
+        pre-commit = git-hooks.lib.${system}.run {
+          src = src;
+          hooks = {
+            hlint.enable = true;
+            fourmolu.enable = true;
+            hpack.enable = true;
+            nixfmt-rfc-style.enable = true;
+            flake-checker = {
+              enable = true;
+              args = [ "--no-telemetry" ];
+            };
+            check-merge-conflicts.enable = true;
+          };
+        };
+
         shellCommon = version: {
-          inherit (self.checks.${system}.pre-commit-check) shellHook;
+          inherit (pre-commit) shellHook;
           buildInputs = with pkgs.haskell.packages."ghc${version}"; [
             cabal-install
             haskell-language-server
@@ -143,39 +151,22 @@
           version: pkgs.haskell.lib.justStaticExecutables self.packages.${system}."ghc${version}-example";
       in
       {
-        checks =
-          {
-            pre-commit-check = git-hooks.lib.${system}.run {
-              src = src;
-              hooks = {
-                # hlint.enable = true;
-                # fourmolu.enable = true;
-                hpack.enable = true;
-                nixfmt-rfc-style.enable = true;
-                flake-checker = {
-                  enable = true;
-                  args = [ "--no-telemetry" ];
-                };
-                check-merge-conflicts.enable = true;
-              };
-            };
-          }
-          // (builtins.listToAttrs (
-            builtins.concatMap (version: [
-              {
-                name = "ghc${version}-check-${packageName}";
-                value = pkgs.runCommand "ghc${version}-check-${packageName}" {
-                  buildInputs = [ self.packages.${system}."ghc${version}-${packageName}" ];
-                } "touch $out";
-              }
-              {
-                name = "ghc${version}-check-example";
-                value = pkgs.runCommand "ghc${version}-check-example" {
-                  buildInputs = [ (examples-exe version) ];
-                } "type example; touch $out";
-              }
-            ]) ghcVersions
-          ));
+        checks = builtins.listToAttrs (
+          builtins.concatMap (version: [
+            {
+              name = "ghc${version}-check-${packageName}";
+              value = pkgs.runCommand "ghc${version}-check-${packageName}" {
+                buildInputs = [ self.packages.${system}."ghc${version}-${packageName}" ];
+              } "touch $out";
+            }
+            {
+              name = "ghc${version}-check-example";
+              value = pkgs.runCommand "ghc${version}-check-example" {
+                buildInputs = [ (examples-exe version) ];
+              } "type example; touch $out";
+            }
+          ]) ghcVersions
+        );
 
         apps =
           {