Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Failure #11

Closed
seanhess opened this issue Dec 18, 2024 · 3 comments
Closed

CI Failure #11

seanhess opened this issue Dec 18, 2024 · 3 comments

Comments

@seanhess
Copy link
Owner

@Skyfold looks like the new CI is failing. Can you fix? Did I mess something up on a merge?

@Skyfold
Copy link
Contributor

Skyfold commented Dec 18, 2024

No, not at all. I forgot to remove the hpack pre-commit check. I put it in because I forgot to run hpack for a few commits.

The fix is to remove line 145 in flake.nix hpack.enable = true;.

The problem is that the hpack version in nixpkgs is 0.36.1 while the one you have is 0.37.0. In truth, this makes the check quite brittle.

Here is the error from the CI that shows the issue:

       > --- This file has been generated from package.yaml by hpack version 0.37.0.
       > +-- This file has been generated from package.yaml by hpack version 0.36.1.

I'll write some details on how the flake.nix works to make it easier to debug CI.

@seanhess
Copy link
Owner Author

Fixed?

@Skyfold
Copy link
Contributor

Skyfold commented Dec 20, 2024

Yes, I forgot say #12 fixes this issue.

I'm holding off writing nix docs until I figure out how to integrate with nix flake-parts projects like co-log-effectful.

Thanks for adding me as a contributor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants