Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger a merged build per pipeline rather than step #6

Open
zsims opened this issue Jun 13, 2018 · 3 comments
Open

Trigger a merged build per pipeline rather than step #6

zsims opened this issue Jun 13, 2018 · 3 comments

Comments

@zsims
Copy link
Contributor

zsims commented Jun 13, 2018

If the build pipeline has multiple steps, then multiple merge builds will be triggered. There should be only merged build triggered.

zsims added a commit that referenced this issue Jun 14, 2018
Additionally documents checkout vs trigger modes, closing #6
zsims added a commit that referenced this issue Jun 14, 2018
Additionally documents checkout vs trigger modes, closing #6
zsims added a commit that referenced this issue Jun 14, 2018
Additionally documents checkout vs trigger modes, closing #6
zsims added a commit that referenced this issue Jun 14, 2018
Additionally documents checkout vs trigger modes, closing #6
@flexportnes
Copy link

I'm interested in using this plugin over our home-grown solution, however we would need this functionality before switching. We currently pin the commit that will be merged into the PR as an artifact/metadata so that there's a consistent merge for all of the different steps, even if new commits are added to the target branch.

@zsims
Copy link
Contributor Author

zsims commented Mar 28, 2019

The plugin can do what's in this bug, it's just about avoiding duplicate builds on:

steps:
  - label: 'Make something'
    commands:
      - make something
    plugins:
      - seek-oss/github-merged-pr#v1.0.1:
          mode: trigger

  - label: 'Make something else'
    commands:
      - make something-else
    plugins:
      - seek-oss/github-merged-pr#v1.0.1:
          mode: trigger

The idea was to set metadata to make sure it's only triggered once. Regardless if you have multiple steps. Is that what you're after?

@flexportnes
Copy link

Not really-- our issue comes from if you have steps that don't start for a while in a build, or if you retry a step, you can get into a state where the merge ref from master isn't the same across all steps since each step performs the merge into the pr branch independently.

Maybe I'm misunderstanding how it works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants