Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused template_id from controlled vocabularies #2103

Open
kdp-cloud opened this issue Jan 7, 2025 · 0 comments
Open

Remove unused template_id from controlled vocabularies #2103

kdp-cloud opened this issue Jan 7, 2025 · 0 comments
Assignees
Labels
Milestone

Comments

@kdp-cloud
Copy link
Collaborator

The sample_controlled_vocabs table in the schema has an unused template_id field which is not being used in any of our SEEK instances.

SampleControlledVocab.select {|scv| !scv.template_id.nil?}
  SampleControlledVocab Load (0.3ms)  SELECT "sample_controlled_vocabs".* FROM "sample_controlled_vocabs"
 => []

Instead the relation to the template should be made through the template attributes, similar to how it's done for sample types.

@kdp-cloud kdp-cloud added the bug label Jan 7, 2025
@kdp-cloud kdp-cloud added this to the 1.17.0 milestone Jan 7, 2025
@kdp-cloud kdp-cloud self-assigned this Jan 7, 2025
@kdp-cloud kdp-cloud added this to DataHub Jan 7, 2025
@github-project-automation github-project-automation bot moved this to Requirements in DataHub Jan 7, 2025
@kdp-cloud kdp-cloud mentioned this issue Jan 7, 2025
@kdp-cloud kdp-cloud moved this from Requirements to Backlog in DataHub Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

1 participant