Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward signals from entrypoint script for custom docker builds #1111

Open
augray opened this issue Jan 3, 2024 · 0 comments
Open

Forward signals from entrypoint script for custom docker builds #1111

augray opened this issue Jan 3, 2024 · 0 comments

Comments

@augray
Copy link
Member

augray commented Jan 3, 2024

When a docker image is built using the docker builder, it uses an entrypoint bash script defined here. If the k8s pod this is running in receives a signal (ex: SIGTERM), the entrypoint.sh process will receive the signal, but the python interpreter it spawned will not. We should change that so that the script forwards the signal, and exits with the exit code of its child.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant