Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: consider inlining "github.com/sendgrid/rest" #492

Open
nikolaydubina opened this issue Jan 16, 2025 · 0 comments
Open

proposal: consider inlining "github.com/sendgrid/rest" #492

nikolaydubina opened this issue Jan 16, 2025 · 0 comments

Comments

@nikolaydubina
Copy link

nikolaydubina commented Jan 16, 2025

this package has no go module.
so we don't easily known what it imports.

reading code I see it imports github.com/sendgrid/rest.
but it also has no go module.
also not clear what it imports.
the meat of that package is only couple lines of code, and lots of documentation.

what's more important, hashes of dependencies and versions not pinned.

this obscurity makes us not to use official sendgrid go client.

consider removing all unnecessary dependencies to improve outlook of this client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant