Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Letsencrypt and filenames provided by registrar #392

Open
sk33lz opened this issue May 8, 2019 · 0 comments
Open

Add support for Letsencrypt and filenames provided by registrar #392

sk33lz opened this issue May 8, 2019 · 0 comments

Comments

@sk33lz
Copy link

sk33lz commented May 8, 2019

Renaming certs, especially letsencrypt certs is problematic for several reasons, mostly security. It would be ideal if SSL certs could be managed by Letsencrypt, as they are free and can be setup easily as part of the installation process, or requirements prior to installation. For those using traditional registrars to manage SSL certs it would also be nice to leave certs named as registrars provide them to make setting up SSL more seamless in this application.

I see the filenames for certs are hardcoded into the server.js file, but ideally those could be defined as environment variables in the docker-compose file as a full path pointing to letsencrypt certs in /etc/letsencrypt/live/[domain.tld] with values:

  • cert.pem
  • chain.pem
  • fullchain.pem
  • privkey.pem

Perhaps just providing the full path for each file is best, as that will allow cert, chain, and key files to be setup no matter what the path and/or filename is.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant