Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WGSL: There is no texture_1d_array type in WGSL #5223

Closed
aleino-nv opened this issue Oct 3, 2024 · 6 comments
Closed

WGSL: There is no texture_1d_array type in WGSL #5223

aleino-nv opened this issue Oct 3, 2024 · 6 comments
Assignees
Labels
goal:forward looking Feature needed at a later date, not connected to a specific use case. kind:enhancement a desirable new feature, option, or behavior

Comments

@aleino-nv
Copy link
Collaborator

aleino-nv commented Oct 3, 2024

This issue was split from #5172.

Affected tests under tests/compute (currently disabled):

  • texture-get-dimensions
  • texture-sampling
  • texture-simple

Output from slang-test for texture-simple:

...
WGPU error: Error while parsing WGSL: :11:40 error: unresolved type 'texture_1d_array'
@binding(4) @group(0) var t1DArray_0 : texture_1d_array<f32>;
...

Tasks:

  • conditionally compile out the affected parts of the test case
  • Try to enable the tests listed above
@aleino-nv aleino-nv added kind:enhancement a desirable new feature, option, or behavior goal:forward looking Feature needed at a later date, not connected to a specific use case. labels Oct 3, 2024
@bmillsNV bmillsNV added this to the Q4 2024 (Fall) milestone Oct 3, 2024
@csyonghe
Copy link
Collaborator

csyonghe commented Oct 3, 2024

We should disable the texture 1D portion of the test for wgsl with some #define logic in the test file, and still enable other parts of the test.

@aleino-nv
Copy link
Collaborator Author

We should disable the texture 1D portion of the test for wgsl with some #define logic in the test file, and still enable other parts of the test.

Ok but we should also not generate texture_1d_array, right?
I'd assume usage of 1d texture arrays should be caught by capability system and then reported nicely to the user at compile time.
(Right now we just generate broken WGSL that contains texture_1d_array.)

@csyonghe
Copy link
Collaborator

This shall be done in the same effort to disallow other types such as uint8 etc. We need to extend the capability system to be able to check on type usage. I consider this not directly within the scope of wgsl work.

@csyonghe
Copy link
Collaborator

The focus should be to get all tests that can work on wgpu to pass, and we can defer more restrict checking to the next phase of development.

@aleino-nv
Copy link
Collaborator Author

This shall be done in the same effort to disallow other types such as uint8 etc. We need to extend the capability system to be able to check on type usage. I consider this not directly within the scope of wgsl work.

Ok I will extend #4947 to include this, and make it non-WGSL specific

@aleino-nv
Copy link
Collaborator Author

This shall be done in the same effort to disallow other types such as uint8 etc. We need to extend the capability system to be able to check on type usage. I consider this not directly within the scope of wgsl work.

Ok I will extend #4947 to include this, and make it non-WGSL specific

Done, closing this one and tracking these failing tests in the lower-priority issue mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal:forward looking Feature needed at a later date, not connected to a specific use case. kind:enhancement a desirable new feature, option, or behavior
Projects
None yet
Development

No branches or pull requests

4 participants