-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase slangc option visibility in docs #5425
Merged
csyonghe
merged 9 commits into
shader-slang:master
from
cheneym2:cheneym2/slang_issue_4124
Oct 29, 2024
Merged
Increase slangc option visibility in docs #5425
csyonghe
merged 9 commits into
shader-slang:master
from
cheneym2:cheneym2/slang_issue_4124
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link to slangc command-line reference from readme. readme. Boost the visiblity of the link in the user-guide. Consolidates command-line-slangc.md into the user-guide. Fixes shader-slang#4124
csyonghe
approved these changes
Oct 28, 2024
csyonghe
approved these changes
Oct 29, 2024
@cheneym2 I merged this too soon, can you fix the formatting? We are now enforcing clang-format. |
The failure is at TOT. Kai has a fix for it. https://github.com/shader-slang/slang/pull/5432/files |
I see, no worries then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to slangc command-line reference from readme. Boost the visiblity of the link in the user-guide.
Consolidates command-line-slangc.md into the user-guide.
Fixes #4124