Fix static build and install #6158
Open
+38
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
csyonghe
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Looks good to me! @expipiplus1 can you take a look as well?
|
/format |
expipiplus1
approved these changes
Jan 23, 2025
|
🌈 Formatted, please merge the changes from this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal of the PR is to simplify building statically when used as a submodule by a downstream project.
Fixes #5832 by adding missing STATIC arguments in cmake.
Improves the state on #5821 by fixing build errors, but does not entirely fix the static build install, just disables the failing part. Completely fixing the problem requires being more careful with what dependencies are PRIVATE and PUBLIC or adding additional explicit targets to install.
Also adds an option to disable LTO, this can be useful to limit the size of static libs (
slang.libis currently ~2GB when using LTO).