Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination support #4

Open
brian6932 opened this issue Aug 8, 2024 · 2 comments · May be fixed by #5
Open

Pagination support #4

brian6932 opened this issue Aug 8, 2024 · 2 comments · May be fixed by #5

Comments

@brian6932
Copy link

  1. Google adds tracking params to their pagination URLs, it'd be nice if the addon also filtered that href, this also happens on non-GBV mode (gbv=2). e.g. /search?q=foo&sca_esv=955251e7965fe0d0&sca_upv=1&pws=0&gbv=1&sxsrf=ADLYWIKUyc_nW5pyzS4ZVy-87YfaDNLFCg:1723122443750&ei=C8O0ZpTELZ6z0PEP3LOh0A0&start=10&sa=N -> /search?gbv=1&q=foo&start=10.
  2. The addon stops working when pagination is done inline, try adding https://github.com/machsix/Super-preloader/pull/1295/files this rule as a Custom rule in the Super-preloader UserScript to reproduce.
@brian6932 brian6932 linked a pull request Aug 8, 2024 that will close this issue
Open
@siebenmann
Copy link
Owner

Thank you for the report and pull requests, but unfortunately I've stopped using this addon (it doesn't seem to be necessary in my case any more) and as a result I've stopped maintaining and updating it. (Which I should update the README to say.)

If this addon is useful to you I'd encourage you to fork it and submit it to AMO as a new addon (assuming you need a signed version).

@brian6932
Copy link
Author

Sure, no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Inline pagination support brian6932/gsearch-urlfix
2 participants
@siebenmann @brian6932