Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story Privacy Settings UI issues #13863

Open
3 tasks done
Sagar0-0 opened this issue Dec 31, 2024 · 1 comment · May be fixed by #13892
Open
3 tasks done

Story Privacy Settings UI issues #13863

Sagar0-0 opened this issue Dec 31, 2024 · 1 comment · May be fixed by #13892

Comments

@Sagar0-0
Copy link
Contributor

Guidelines

  • I have searched searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

Steps to do:

  1. Go to stories page
  2. Choose Stories Privacy from Menu
  3. Click on My Story to go to Privacy Settings.
  4. Click on any of the options from All except... or Only share with..., which will navigate us to the ContactSelectionListFragment.

Issues:

  1. The Select All button does not update the UI.
  2. The done button should be visible only if the Selected item is more than 0. (Logically expected behavior)

I am ready with a PR, please approve this improvement and assign this issue to me.

Screenshots

document_6312069446429055630.mp4

Device

No response

Android version

14

Signal version

7.28.4

Link to debug log

NA

@Sagar0-0
Copy link
Contributor Author

We can optionally add the Header action of Unselect all. When we click on Select all (which I have fixed now), we can change that option to Unselect all. by checking a variable from the ViewModel named isAllSelected.
And if unselect all clicked, we reset the list and the isAllSelected. and HeaderAction is again reset to Select All.
If user decides to click on the chip or deselect one contact, then we can check if list is empty || isAllSelected is false. then change the HeaderAction back.

Sagar0-0 added a commit to Sagar0-0/Signal-Android that referenced this issue Jan 8, 2025
@Sagar0-0 Sagar0-0 linked a pull request Jan 8, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant