Fixes #13870 - Showing SwipeProgressBar on Remove/Block contact #13896
+34
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| })); | ||
| if (isRecipientCanBeRemoved(recipient.getId())) { | ||
| disposables.add(viewModel.hideContact(recipient).subscribe(() -> { | ||
| handleManualRefresh(); |
There was a problem hiding this comment.
I think the whole PR can be reduced down to just this line. I think all we need to do is show the refresh indicator, nothing else. Which I think could be accomplished with replacing onRefresh() with handleManualRefresh()?
There was a problem hiding this comment.
The check i have added is for the following shown scenerio where user might try to again remove/block the Recipient while it is already in process of blocking/removing or already removed....
VID_20250110_220903_364.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13870
First time contributor checklist
Contributor checklist
Fixes #1234syntaxDescription
Call
handleManualRefreshto show the progress bar. An Important check is addedisRecipientPresent, so that when the user might have the dialog opened when contact is being removed or blocked, then the operation can not be performed again after progress is completed. This will prevent any unwanted exceptions or DB calls.This
isRefreshingfunction is already present in #13874