Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate better pagination options for Greg\EventQuery #15

Open
sdunham opened this issue Jun 12, 2021 · 0 comments
Open

Investigate better pagination options for Greg\EventQuery #15

sdunham opened this issue Jun 12, 2021 · 0 comments

Comments

@sdunham
Copy link
Contributor

sdunham commented Jun 12, 2021

We're currently setting 'posts_per_page' => -1 in Greg\EventQuery::params() to ensure that all applicable events are returned based on the current query. Without this, the query would be limited based on the WP posts_per_page setting. But there are probably better and more flexible approaches for this.

See #14 for more context on why this change was implemented in the first place and some potential suggestions for future improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant