Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Eel Helper setText #17

Open
jonnitto opened this issue Nov 19, 2019 · 4 comments
Open

Missing Eel Helper setText #17

jonnitto opened this issue Nov 19, 2019 · 4 comments

Comments

@jonnitto
Copy link
Contributor

It would be nice to have an Eel Helper where I can set the text for the DummyImageSource. If another Source is applied, nothing should happen

@mficzel
Copy link
Member

mficzel commented Sep 1, 2020

@jonnitto why do you not use the override options of fusion:

prototype(Sitegeist.Kaleidoscope:DummyImageSource) {
   text = ${"your expression"}
}

@jonnitto
Copy link
Contributor Author

jonnitto commented Sep 3, 2020

Because you could set the text in the presentation component

@mficzel
Copy link
Member

mficzel commented Sep 3, 2020

Ahhh. i understand, it was not intended to be used like this. When i use this in the presentation component it is uauslly as @styleguide.props.imageSource and i can adjust the text and color there.

Why would a presentation component want to adjust that?

@jonnitto
Copy link
Contributor Author

jonnitto commented Sep 4, 2020

Because you can give the editor some information about the picture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants