Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math in breakpoint-max mixin no longer working in newer version of Sass #29

Open
jmcgaha opened this issue Mar 28, 2018 · 1 comment
Open
Assignees

Comments

@jmcgaha
Copy link

jmcgaha commented Mar 28, 2018

After recently upgrading to gulp-sass 3.2.1 which uses node-sass 4.8.3, the math to subtract 1px no longer works leaving me things like:

max-width(48em - 0.0625em) in the processed CSS which does not work in the browser.

As a workaround I had to remove the px to em conversion for that 1px and for each breakpoint size.
Could be related to #28, but I tried some of the suggested methods and it still wasn't working.

$val: #{map-get($breakpoints, $breakpoint)} - em(1px);

@ulinaaron
Copy link
Collaborator

Thanks @jmcgaha! I'll take a look at this and see if I can get a refactor for the current version of Tent.

@ulinaaron ulinaaron self-assigned this Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants