Skip to content
This repository has been archived by the owner on Aug 13, 2024. It is now read-only.

Dates in CHANGELOG #13

Open
lukeindykiewicz opened this issue Nov 28, 2019 · 2 comments
Open

Dates in CHANGELOG #13

lukeindykiewicz opened this issue Nov 28, 2019 · 2 comments

Comments

@lukeindykiewicz
Copy link

I have mixed feelings about Update dates in CHANGELOG point from the release todo list, because all we did with rewriting commits was to only drop last commit (Bump to M/rc) before release. CHANGELOG is changed in Prepare for release commit, so I would need to rewrite it (or add one more commit).
The two rules contradicts each other, imho.

@dilyand
Copy link
Contributor

dilyand commented Nov 29, 2019

I think the idea is that you:

  1. Change the date in the CHANGELOG
  2. git commit -m "Prepare for release" << this leaves you with two "Prepare for release" commits
  3. git rebase -i ... and squash "Prepare for release" commits.

The "Prepare for release" commit is not itself part of the CHANGELOG.

@chuwy
Copy link
Contributor

chuwy commented Nov 29, 2019

Release date is when assets became available (and ideally when they were announced). This cannot be changed.

In many cases we know when asset will go live and the date remains unchanged. If we didn't do planning very well and asset goes live on the other date - it needs to be changed in Prepare for release, no additional commit necessary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants