Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default dmesg whitelist should be updated for the new network interface name style #363

Open
fsfod opened this issue Nov 10, 2017 · 5 comments
Assignees

Comments

@fsfod
Copy link
Contributor

fsfod commented Nov 10, 2017

Theses are the the messages I'm seeing on bencher3.

[ 4.873919] r8169 0000:06:00.0 enp6s0: link up
[ 377.233591] random: crng init done

https://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames/

Names incorporating Firmware/BIOS provided index numbers for on-board devices (example: eno1)
Names incorporating Firmware/BIOS provided PCI Express hotplug slot index numbers (example: ens1)
Names incorporating physical/geographical location of the connector of the hardware (example: enp2s0)
Names incorporating the interfaces's MAC address (example: enx78e7d1ea46da)

@ltratt
Copy link
Member

ltratt commented Nov 11, 2017

It's not totally clear to me whether the default list should include this or whether users should be encouraged to add it to their config files. I think i'm inclined towards the latter, but can be persuaded the other way.

@fsfod
Copy link
Contributor Author

fsfod commented Nov 11, 2017

The default list already filters out the old "eth" variant and has this comment.
# Bringing the network up and down on Linux (which some experiments may wish to do) makes some noise. Ignore.

@ltratt
Copy link
Member

ltratt commented Nov 11, 2017

Yes, but in a sense that's its weakness: we hardcoded in something which Linux has now changed. That said, given that we allow users to override the whitelist, updating the defaults is probably safe enough.

@vext01
Copy link
Member

vext01 commented Nov 13, 2017

We just need to make the regex more general to match any driver name.

@ltratt
Copy link
Member

ltratt commented Jul 23, 2018

I still think I'm inclined towards saying this should be wholly in the user's config file. If so, all we'd have to do is delete the regex's from the main code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants