This repository has been archived by the owner on Sep 10, 2019. It is now read-only.
Create existing_payment/_stripe.html.erb #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm having this issue as well. Thanks for making a pull! Not sure why they haven't merged it yet. |
|
This definitely should be merged in for all stores using Stripe and |
|
Sorry, that this took so long. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #48, Solidus 2.2 created the need for views in the
existing_paymentfolder, but no such views exist insolidus_gateway. This created issues where customers could not checkout usingsolidus_gatewaymethods (in our case, Stripe).This PR creates a primitive
_stripeview which just renders the default gateway view. Nothing special, but it should fix this issue.This may also fix #30 as well, depending on what exactly was the root cause of that.