-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No breadcrumbs when clicking on a homepage product #130
Comments
This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions. |
this is infact broken, so the question is which taxon we pick for creating the breadcrumbs on the product page, @jarednorman @tvdeyen @kennyadsl do you have any preferences as we will treat this topic next week when we start SEO on the front-end. |
Every shop I worked with has a different understanding of what the main taxonomy (most of the time referred to as "Category") is. Some refer to as the "Storefront" taxonomy, some call it "Navigation", etc. I can see that there is an urge for at least something that is been used as the main product category. We could make it configurable and default to a taxonomy with a "Category" name or add a flag to the taxonomies table (ie. I am open to suggestions. |
Hey, is there any reason not to define a category as primary by a checkbox or a flag? |
besides writing the code. writing the tests. maintaining them and fix edge cases for ever? nothing actually |
Would you live with it if we contribute it? While I feel that the brand solution was ok (though I would have preferred something more stable) here I really struggle with outcome variability and would strongly push for a way on product level to determine "the taxon" to be used. I'd be really flexible on implementation here and grateful for any hint on the easiest to maintain way. |
@jarednorman can you give an input? |
I'm fine with having a configurable way for stores to choose what taxonomy to use for breadcrumbs when the taxon param isn't present. |
@jarednorman What should happen if the taxon param is not empty? We just placed brands in that param. |
Wouldn't it be more intuitive to also define the brand at this point be part of a similar structure to avoid mixups? |
I don't know if we can consider this a bug, but we could try to see if we can have the same behavior for the following 2 cases:
On the homepage I click on a product (ex. http://localhost:3000/products/solidus-t-shirt):
On a category page (ex. http://localhost:3000/t/categories/clothing) I click on a product (ex. http://localhost:3000/products/solidus-t-shirt?taxon_id=3 <= taxon id is in the URL)
The text was updated successfully, but these errors were encountered: