Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing available payment method rendering for orders fully covered by Store Credits #345

Closed
rainerdema opened this issue Jun 27, 2023 · 0 comments · Fixed by #348
Closed
Assignees

Comments

@rainerdema
Copy link
Contributor

rainerdema commented Jun 27, 2023

Short-Term Solution

Desired Behavior

We want to prevent the rendering of available payment methods if the order will be fully covered by store credits. The primary issue is that having a $0 checkout due to full coverage by store credits can interfere with the regular checkout process. (See solidusio/solidus_stripe#307).
Our plan is to display a clear message indicating that the order is fully covered by store credits and remove the need for additional payment method selection.

Current Behavior

Currently, if an order is fully covered by store credits, the system still permits selection of a payment method. This often results in payments being created in the checkout state, which can get invalidated when store credits are added.

Screenshot 2023-05-25 at 17 29 31

Additional notes

Please note that there are edge cases where this solution may not cover the payment invalidation problem.
For example, if a user selects a payment method and then moves from the payment step to the confirm step, the issue may still arise if the user goes back to the payment step and selects and fills another payment method.

For more details about the long-term solution, refer to #346.

For more information about these proposed solutions, please refer to solidusio/solidus#5109 (comment).
This issue contains additional discussion and context about the identified problems and the suggested solutions to improve the store credit flow in Solidus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant