Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions currently failing on sqlite after latest changes to promotion system #311

Open
fthobe opened this issue Jan 2, 2025 · 1 comment
Labels
bug Describes or fixes a bug.

Comments

@fthobe
Copy link

fthobe commented Jan 2, 2025

Hey @mamhoff

@shahmayur001 fixed the tests and made the gem work with 4.x on starter frontend, but it seems there are some issues with the new promotion system on 4.4.2 (4.4.1 did install and function correctly).

We are experiencing some issues with:

  1. installing on solidus with the new promotion gem
  2. tests are failing again after they worked (more or less flawlessly) on PR

Can you help us to wrap this up and make it all work so that @jarednorman and @kennyadsl can wrap it up into a release?

@shahmayur001 please post the error messages.

Solidus Version:
4.4.2

To Reproduce
Install current subscription main gem over 4.4.2.

image

@fthobe fthobe added the bug Describes or fixes a bug. label Jan 2, 2025
@fthobe
Copy link
Author

fthobe commented Jan 2, 2025

Installation Issues

image (1)
image (2)

@fthobe fthobe changed the title Subscriptions currently failing after latest changes to promotion system Subscriptions currently failing on sqlite after latest changes to promotion system Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Describes or fixes a bug.
Projects
None yet
Development

No branches or pull requests

1 participant