Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate migration helper #56

Open
aldesantis opened this issue Nov 10, 2020 · 1 comment · May be fixed by #96
Open

Deprecate migration helper #56

aldesantis opened this issue Nov 10, 2020 · 1 comment · May be fixed by #96
Milestone

Comments

@aldesantis
Copy link
Member

Our migration helper was introduced for supporting the upgrade from Rails 4.2 to 5.x, which introduced support for migration versions.

Now that we don't support 4.2 anymore (the earliest Rails version supported by Solidus 2.9 is 5.1), we can deprecate the helper and simply use ActiveRecord::Migration#[] instead.

@stale
Copy link

stale bot commented Nov 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 11, 2022
@gsmendoza gsmendoza removed the wontfix label Nov 11, 2022
@tvdeyen tvdeyen added this to the 1.0 milestone Jan 24, 2025
@tvdeyen tvdeyen linked a pull request Jan 24, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants