You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, we have two separate functions that call the pipeline, and are both present in the run_pipeline.py script. Those functions differ only by the second having a custom value for jump detection threshold in the jump step. Now that we have a way to pass in custom parameters, even when calling the script as a subprocess, there's no reason to maintain separate versions of the same function, and a lot of reasons to go with the simpler solution of setting custom parameters when calling the pipeline function in the first place.
@mfixstsci @york-stsci Ok, everything seems to be working well on the dev server. I've re-added the line with the jump step threshold. It would be nice to remove that in a separate PR in the not too distant future. We could always update the bad pixel monitor at the same time to have it pass the same parameter to its pipeline call, so nothing would change there. I just don't like the idea of forcing all monitors that use the current pipeline functions to not be able to adjust the parameter value.
Right now, we have two separate functions that call the pipeline, and are both present in the run_pipeline.py script. Those functions differ only by the second having a custom value for jump detection threshold in the jump step. Now that we have a way to pass in custom parameters, even when calling the script as a subprocess, there's no reason to maintain separate versions of the same function, and a lot of reasons to go with the simpler solution of setting custom parameters when calling the pipeline function in the first place.
Originally posted by @bhilbert4 in #1262 (comment)
The text was updated successfully, but these errors were encountered: