Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove save_jump_pipeline as a separate function, and instead pass in the custom parameters when calling the pipeline from the bad pixel monitor #1296

Open
york-stsci opened this issue Jul 28, 2023 · 0 comments
Assignees

Comments

@york-stsci
Copy link
Collaborator

Right now, we have two separate functions that call the pipeline, and are both present in the run_pipeline.py script. Those functions differ only by the second having a custom value for jump detection threshold in the jump step. Now that we have a way to pass in custom parameters, even when calling the script as a subprocess, there's no reason to maintain separate versions of the same function, and a lot of reasons to go with the simpler solution of setting custom parameters when calling the pipeline function in the first place.

          @mfixstsci @york-stsci Ok, everything seems to be working well on the dev server. I've re-added the line with the jump step threshold. It would be nice to remove that in a separate PR in the not too distant future. We could always update the bad pixel monitor at the same time to have it pass the same parameter to its pipeline call, so nothing would change there. I just don't like the idea of forcing all monitors that use the current pipeline functions to not be able to adjust the parameter value.

Originally posted by @bhilbert4 in #1262 (comment)

@york-stsci york-stsci self-assigned this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant