Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove preview image and thumbnail inventory files #1029

Closed
bhilbert4 opened this issue Aug 25, 2022 · 3 comments · Fixed by #1667
Closed

Remove preview image and thumbnail inventory files #1029

bhilbert4 opened this issue Aug 25, 2022 · 3 comments · Fixed by #1667
Labels
enhancement preview_images/thumbnails

Comments

@bhilbert4
Copy link
Collaborator

These files are difficult to work with, and don't seem to offer much value. They were originally implemented as a time-saving feature (over using glob), but the amount of time saved as the number of files becomes very large isn't clear, and any extra time might be worth it in return for easier maintenance.
@stscijgbot-jwql
Copy link
Collaborator

This issue is tracked on JIRA as JWQL-222.

@stscijgbot-jwql
Copy link
Collaborator

Comment by Bryan Hilbert on JIRA:

Looks like we no longer use these inventory files to check if a preview image exists, but we are still updating the files when we create new preview images. We should delete those files and remove the code that writes to them.

@bhilbert4 bhilbert4 mentioned this issue Jan 15, 2025
Merged
@stscijgbot-jwql
Copy link
Collaborator

Comment by Bryan Hilbert on JIRA:

Fix is in #⁠1667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement preview_images/thumbnails
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove support for preview image and thumbnail listfiles bhilbert4/jwql
2 participants
@bhilbert4 @stscijgbot-jwql