Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stempler] Stempler trying to parse url with @^ characters #331

Closed
rauanmayemir opened this issue Aug 18, 2020 · 1 comment · Fixed by #1197
Closed

[stempler] Stempler trying to parse url with @^ characters #331

rauanmayemir opened this issue Aug 18, 2020 · 1 comment · Fixed by #1197
Assignees
@butschster
Labels
Component: Stempler Feature
Milestone
3.14

Comments

@rauanmayemir
Copy link
Contributor

If I put something like

<link rel="stylesheet" href="https://unpkg.com/tailwindcss@^1.6/dist/tailwind.min.css" />

in my stempler templates, it will fail with Directive not parsed exception.

The solution would be suppressing it like @@^ which seems to be an okay solution, but might be confusing to newbies.
@SerafimArts SerafimArts transferred this issue from spiral/stempler Sep 19, 2020
@SerafimArts SerafimArts changed the title Stempler trying to parse url with @^ characters [stempler] Stempler trying to parse url with @^ characters Sep 19, 2020
@wolfy-j wolfy-j added this to the 3.0 milestone May 27, 2021
@butschster butschster moved this to Todo in Spiral framework Aug 25, 2022
@butschster butschster modified the milestones: 3.0, 3.1 Sep 14, 2022
@butschster butschster modified the milestones: 3.1, 3.4 Nov 21, 2022
@butschster butschster modified the milestones: 3.4, 3.5 Dec 13, 2022
@butschster butschster modified the milestones: 3.5, 3.8 Apr 18, 2023
@butschster butschster removed this from the 3.8 milestone Aug 15, 2023
@butschster butschster added this to the 3.14 milestone Jan 6, 2025
@butschster butschster assigned butschster and unassigned msmakouz Jan 6, 2025
@butschster butschster moved this from Todo to In Progress in Spiral framework Jan 6, 2025
@butschster butschster mentioned this issue Jan 6, 2025
Merged
@butschster butschster linked a pull request Jan 6, 2025 that will close this issue
fix: Fixes the problem when stempler tries to parse @ char inside a string that is not a directive. #1197
Merged
@butschster butschster moved this from In Progress to In review in Spiral framework Jan 6, 2025
@butschster
Copy link
Member

Hey @rauanmayemir, thanks for the bug report!

After 4 years, I finally found a workaround to fix the issue you reported! 😄
Hopefully, this helps you wrap up your project once we release the new version with the bugfix.

You're welcome! 🚀

@github-project-automation github-project-automation bot moved this from In review to Done in Spiral framework Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@butschster butschster

Labels
Component: Stempler Feature
Projects
Spiral framework
Status: Done
Milestone
3.14
5 participants
@rauanmayemir @butschster @wolfy-j @SerafimArts @msmakouz