Odd code found for PyQt5 in tests/conftest.py: importing too much?

[StSav012]

Shouldn't there be QtCore instead of just Qt?

qtpy/qtpy/tests/conftest.py

Lines 23 to 27 in cd0b49b

	try:
	from PyQt5 import Qt
	versions += f"PyQt: {Qt.PYQT_VERSION_STR} - Qt: {Qt.QT_VERSION_STR}"
	except ImportError:

For PyQt6, it is so:

qtpy/qtpy/tests/conftest.py

Lines 48 to 54 in cd0b49b

	try:
	from PyQt6 import QtCore
	versions += (
	f"PyQt: {QtCore.PYQT_VERSION_STR} - Qt: {QtCore.QT_VERSION_STR}"
	)
	except ImportError:

[dalthviz]

Hi @StSav012 thanks for the report! Checking for me that code works 🤔

What version of PyQt5 are you using for it to raise an error?

[StSav012]

That's embarrassing for me. I must have checked it wrongly. But anyway, the import seems to load just everything:

from PyQt5 import Qt  # for the following line to work
# Now, `PyQt5.__all__` seems to be populated.
from PyQt5 import *

print(
    set(Qt.__dir__()) == \
    set(
        sum(
            (
                m.__dir__()
                for n, m in sys.modules.items()
                if n.startswith("PyQt5.Qt") and n != "PyQt5.Qt"
            ),
            [],
        )
    )
)

Does it necessary to get only a version string?

[dalthviz]

Does it necessary to get only a version string?

I think that's the case. The import is only meant to check that the binding is importable/available and to get the relevant info about the version available. Not totally sure if there is also some other reason why for the PyQt5 case the Qt import is done though 🤔 Is there any other reason to use the from PyQt5 import Qt to get the version @ccordoba12 ?

[ccordoba12]

Is there any other reason to use the from PyQt5 import Qt to get the version @ccordoba12 ?

Probably for compatibility with PyQt4. I'd say we should change it to from PyQt5 import QtCore if it works without problems.