Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is redundant to git clone TensorFlow repo. #2243

Open
workingloong opened this issue Aug 14, 2020 · 2 comments
Open

It is redundant to git clone TensorFlow repo. #2243

workingloong opened this issue Aug 14, 2020 · 2 comments

Comments

@workingloong
Copy link
Collaborator

We only need those proto files to build elasticdl.proto, so we can only download those files by wget. Because TensorFlow repo is huge which makes the image huge.

ENV TF_PATH /tmp/tensorflow
RUN cd /tmp \
&& git clone --depth=1 --branch v2.2.0-rc0 \
https://github.com/tensorflow/tensorflow

@egolearner
Copy link

You can delete unnecessary files after cloning TensorFlow in the same RUN command. It will both keep the image small and avoid wget network issue.

@workingloong
Copy link
Collaborator Author

You can delete unnecessary files after cloning TensorFlow in the same RUN command. It will both keep the image small and avoid wget network issue.

Good suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants