Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect minimum should be useful during initial rounds. #134

Open
MicahZoltu opened this issue Jun 18, 2017 · 3 comments
Open

Collect minimum should be useful during initial rounds. #134

MicahZoltu opened this issue Jun 18, 2017 · 3 comments

Comments

@MicahZoltu
Copy link

https://github.com/status-im/status-network-token/blob/master/migrations/2_deploy_contracts.js#L60-L64

The last parameter, collectMinimum is currently set to 10^12. This means that the min per-transaction buy-in is about $0.00035 USD. This is significantly less than the cost of gas required to buy-in, which means the long-tail is really long and effectively needlessly burning people's gas for no gain.

The min value on each curve point should be at least 1 attoeth higher than expected gas costs. Since we know the max gas price, it should be pretty easy to calculate the expected gas cost for a transaction and then set the minimum to be higher than that.

@nfnty
Copy link
Contributor

nfnty commented Jun 18, 2017

All parameters in the migrations scripts are for testing purposes only. Read INSTRUCTIONS.md if you want to know more.

@MicahZoltu
Copy link
Author

With mere hours before the deploy, the actual deployment scripts should be put into GitHub so the community has time to review them. It would not be good to deploy with non-public scripts because it makes auditing really hard as the auditors will need to look to see what is actually being submitted to the chain and then guess at what was being attempted. And they only will have 24 hours to do this.

@jbaylina
Copy link
Contributor

All the contracts will be deployed and verified in the Mainchain with enough time to be reviewed by the community. It's important not only to verify the code but also the different parameters set during the deployment of those contracts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants