Hoist trans bug with index into derived type

[vkatkinson]

With NEMO file lbcnfd.f90:

   integer :: ij1
    integer :: ij2

    do jf = 1, kfld, 1
      ipi = SIZE(ptab(jf)%pt4d, 1)
      ipj = SIZE(ptab(jf)%pt4d, 2)
      ipk = SIZE(ptab(jf)%pt4d, 3)
      ipl = SIZE(ptab(jf)%pt4d, 4)
      ihls = (ipi - Ni0glo) / 2
      if (c_NFtype == 'T') then
        if (cd_nat(jf) == 'T' .OR. cd_nat(jf) == 'W') then
          do jl = 1, ipl, 1
            do jk = 1, ipk, 1

With hoist_expressions=True in omp_gpu_trans.py PSyclone generates:

 integer :: loop_stop_15
    integer :: loop_stop_16

    ipi = SIZE(ptab(jf)%pt4d, 1)
    ipj = SIZE(ptab(jf)%pt4d, 2)
    ipk = SIZE(ptab(jf)%pt4d, 3)
    ipl = SIZE(ptab(jf)%pt4d, 4)
    ihls = (ipi - Ni0glo) / 2
    do jf = 1, kfld, 1
      if (c_NFtype == 'T') then
        if (cd_nat(jf) == 'T' .OR. cd_nat(jf) == 'W') then
          loop_stop = Ni0glo - 1
          loop_stop_2 = ihls - 1
          loop_stop_3 = Ni0glo / 2 - 1

[arporter]

Happily, it seems that the improvements to reference_accesses in #2825 fix this bug. I'll add the test I have here to that PR.